This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(mdTabs): Tab label width correction in mdDialog #5017
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Tab label width is set correctly when used in a dialog. Changed one line to a previous version (1 commit prior to 4a16038) That commit addressed issue angular#4743. This issue is not reproduced by reverting this line of code. Addressing issues angular#4834 angular#4873 angular#4744
|
@robertmesserle - can you review ? |
|
@ThomasBurleson This looks like it would break other use-cases. Still looking though. |
|
Update: After looking through other bugs, this DOES introduce new bugs. We will have to look into other workarounds for this. |
|
I believe I have a proper fix for this. Closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tab label width is set correctly when used in a dialog.
Changed one line to a previous version (1 commit prior to 4a16038)
That commit addressed issue #4743. This issue is not reproduced by reverting this line of code.
Addressing issues #4834 #4873 #4744